[aarch64-port-dev ] RFR: AARCH64: Fix for failed sha tests (compiler/intrinsics/sha)

Alexeev, Alexander Alexander.Alexeev at caviumnetworks.com
Mon Jun 1 18:38:53 UTC 2015


Hello

This patch [1] resolves issues with sha related tests (hotspot/test/compiler/intrinsics/sha) failed on aarch64. Names of tests are below.
The problem is that tests have no cases for aarch64 and such architecture falls into "OtherCPU" category which assumed not supporting SHA intrinsics.

Adding test cases for AArch64 solve that.
For "supported" test cases and "specific unsupported" test cases implementation is  just combination with Sparc existed versions by renaming classes and adding predicates for aarch64.
For "unsupported" version dedicated aarch64 test case is created since Sparc version doesn't check -XX:+SHA... options warnings and aarch64 can do what and does.
"supported" - means CPU support SHA instructions  and intrinsics are available
"unsupported" - means CPU doesn't have SHA support

Failed tests:
compiler/intrinsics/sha/cli/TestUseSHA1IntrinsicsOptionOnUnsupportedCPU.java
compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java
compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java
compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java
compiler/intrinsics/sha/sanity/TestSHA1MultiBlockIntrinsics.java
compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java
compiler/intrinsics/sha/sanity/TestSHA256MultiBlockIntrinsics.java

After applying proposed patch new test starts failing until inconsistency in UseSHA flag behavior will be resolved. Details with fix were sent early to the aarch64-port mail list in separate message.
Failing test: compiler/intrinsics/sha/cli/TestUseSHAOptionOnSupportedCPU.java

Jtreg hotspot tests
Before:
Test results: passed: 818; failed: 34; error: 3
After:
Test results: passed: 824; failed: 28; error: 3

Tests weren't executed on SPARC since such arch is unavailable.


Please, review and sponsor if approved.

[1] www.googledrive.com/host/0B5VQvD5uJjDQfmt3OXBJWHFTc2RQN0RsNUpNZ1ZDUFdPSno3VW12eUJnR0Y0TWszNHpaSEU<http://www.googledrive.com/host/0B5VQvD5uJjDQfmt3OXBJWHFTc2RQN0RsNUpNZ1ZDUFdPSno3VW12eUJnR0Y0TWszNHpaSEU>



More information about the aarch64-port-dev mailing list