[aarch64-port-dev ] RFR: 8081790: SHA tests fail

[Vladimir Kozlov]

Changes looks fine to me I will sponsor it.

Thanks,
Vladimir

On 6/12/15 1:59 AM, David Holmes wrote:
> Hi Ed,
>
> On 12/06/2015 6:49 PM, Edward Nevill wrote:
>> Hi,
>>
>> Sorry to bother. The following was posted for review 9 days ago but there
>> has been no response.
>>
>> This is an aarch64 only change to resolve 7 jtreg/hotspot failures.
>>
>> Could a JDK9 reviewer please take a look at this,
>
> The test changes are shared code so this needs someone from the compiler
> team to review and sponsor.
>
> Thanks,
> David
>
>> Thanks,
>> Ed.
>>
>> On 3 June 2015 at 09:51, Edward Nevill <edward.nevill at linaro.org> wrote:
>>
>>> Hi,
>>>
>>> The following webrev
>>>
>>> http://cr.openjdk.java.net/~enevill/8081790/webrev.00/
>>>
>>> fixes a number of SHA test failures on aarch64.
>>>
>>> This patch was contributed by alexander.alexeev at caviumnetworks.com
>>>
>>> Currently the following JTReg/hotspot SHA tests fail on aarch64
>>>
>>> FAILED:
>>> compiler/intrinsics/sha/cli/TestUseSHA1IntrinsicsOptionOnUnsupportedCPU.java
>>>
>>> FAILED:
>>> compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java
>>>
>>> FAILED:
>>> compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java
>>> (ie
>>> FAILED: compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java
>>> FAILED: compiler/intrinsics/sha/sanity/TestSHA1MultiBlockIntrinsics.java
>>> FAILED:
>>> compiler/intrinsics/sha/sanity/TestSHA256MultiBlockIntrinsics.java
>>> FAILED: compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java
>>>
>>> The reason for the test failures is that the test suite is configured on
>>> the assumption that Sparc is the only arch which support SHA in hw (and
>>> therefore supports the -XX:+UseSHA options).
>>>
>>> The webrev adds tests for aarch64.
>>>
>>> The following files have also been renamed as they were inappropriately
>>> named.
>>>
>>> R
>>> test/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForSupportedSparcCPU.java
>>>
>>> R
>>> test/compiler/intrinsics/sha/cli/testcases/UseSHAIntrinsicsSpecificTestCaseForUnsupportedSparcCPU.java
>>>
>>> R
>>> test/compiler/intrinsics/sha/cli/testcases/UseSHASpecificTestCaseForSupportedSparcCPU.java
>>>
>>> R
>>> test/compiler/intrinsics/sha/cli/testcases/UseSHASpecificTestCaseForUnsupportedSparcCPU.java
>>>
>>>
>>> These now become
>>>
>>> A
>>> test/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForSupportedCPU.java
>>>
>>> A
>>> test/compiler/intrinsics/sha/cli/testcases/UseSHAIntrinsicsSpecificTestCaseForUnsupportedCPU.java
>>>
>>> A
>>> test/compiler/intrinsics/sha/cli/testcases/UseSHASpecificTestCaseForSupportedCPU.java
>>>
>>> A
>>> test/compiler/intrinsics/sha/cli/testcases/UseSHASpecificTestCaseForUnsupportedCPU.java
>>>
>>>
>>> (ie. the 'Sparc' has been dropped from the filename as Sparc is no
>>> longer
>>> the only arch which supports SHA).
>>>
>>> Tested with JTReg/hotspot
>>>
>>> Before: Test results: passed: 840; failed: 10; error: 5
>>> After:  Test results: passed: 847; failed: 3; error: 5
>>>
>>> Please review,
>>>
>>> Thanks,
>>> Ed.
>>>
>>>
>>>