[aarch64-port-dev ] RFR: 8129551: some regressions introduced by addition of vectorisation code

[Vladimir Kozlov]

asserts works only in debug VM so I would leave original imm32 &= 0xff and imm32 &= 0xffff.
I think you should also move comments with table to macroAssembler_aarch64.cpp.

Thanks,
Vladimir

On 6/23/15 10:22 AM, Edward Nevill wrote:
> On 23 June 2015 at 11:18, Andrew Haley <aph at redhat.com> wrote:
>
>> On 23/06/15 11:12, Edward Nevill wrote:
>>> This changeset only affects aarch64 files.
>>>
>>> Please review and if OK I will push,
>>
>> Won't this fail to detect an overflow?
>>
>> 1418   if (T == T4H || T == T8H) { imm32 &= 0xffff; nimm32 &= 0xffff; }
>>
>> Otherwise this looks OK to me.
>>
>> Andrew.
>>
>>
> Updated webrev with asserts
>
> http://cr.openjdk.java.net/~enevill/8129551/webrev.01
>
> Could a JDK9 Reviewer please review this,
>
> Thanks,
> Ed.
>