[aarch64-port-dev ] Fix for jdk9/dev build for aarch64

[Andrew Dinn]

On 25/03/15 13:41, Edward Nevill wrote:
> On Wed, 2015-03-25 at 13:35 +0000, Andrew Dinn wrote:
>> On 25/03/15 09:17, Edward Nevill wrote:
>>> Hi Andy,
>>>
>>> Thanks for this.
>>>
>>> Now that the aarch64 port has been merged to jdk9/dev all changes must
>>> be accompanied by an issue report in the JDK bug system at
>>>
>>> http://bugs.openjdk.java.net
>>>
>>> I have already created a report for this issue along with a patch at
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8075860
>>
>> I don't understand what this patch is for. Surely it cannot be needed to
>> make AArch64 builds work?
>>
>> It looks like this is intended to re-enable building of code on x86
>> using the AArch64 simulator (i.e. run make x86 with BUILTIN_SIM=true).
>> If so then
>>
>>   i) I am not sure whether we really want to maintian support for
>> simulator builds on jdk9(+)
>>
>>   ii) I would be very surprised to find that this is the only thing that
>> needs fixing to make the simulator build fully functional again (we lost
>> all the extra shared code changes which were needed to support proper
>> debugging in the upstream merge).
>>
>> Could you please explain the provenance, purpose and value of this patch?
> 
> No. The native build is broken. This fixes it.

Ah ok, got it now. This is a breakage introduced by the Oracle change
set 7995:3eb61269f421 -- as, indeed, it says in the JIRA :-).

I had not seen this because I was working on another patch and had not
yet pulled in the Oracle changes.

Yes, the patch looks good to push.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters
(USA), Michael O'Neill (Ireland)