[aarch64-port-dev ] RFR: 8079564: aarch64: Use FP register as proper frame pointer

[Zoltán Majó]

Hi Ed,


this change looks good to me (I'm not a *R*eviewer).

I was wondering, though, which is the langtools test that passes with 
-XX:-PreserveFramePointer disabled and fails with 
-XX:+PreserveFramePointer. I would like to see if the same problem 
appears on x86. Could you maybe also send me the error message that you get?

Thanks a lot in advance!

Best regards,


Zoltán

On 05/07/2015 04:23 PM, Edward Nevill wrote:
> Hi,
>
> The following webrev adds support for the -XX:+PreserveFramePointer option.
>
> http://cr.openjdk.java.net/~enevill/8079564/webrev.00/
>
> Support for proper frame pointers for use in debug/profile was added to x86 in the following changeset
>
> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/382e9e4b3b71
>
> This webrev mirrors that changeset to add the support to aarch64.
>
> Associated JIRA issue is
>
> https://bugs.openjdk.java.net/browse/JDK-8079564
>
> Tested with JTreg hotspot and langtools.
>
> Without frame pointer (-XX:-PreserverFramePointer) which is the default
>
> Hotspot: passed: 805; failed: 34; error: 3
> Langtools: passed: 3,267; error: 9
>
> With frame pointer (-XX:+PreserveFramePointer)
>
> Hotspot: passed: 805; failed: 34; error: 3
> Langtools: passed: 3,266; error: 10
>
> Thanks for the review!
> Ed.
>
>