[aarch64-port-dev ] RFR: Backports from jdk9 to jdk8

Edward Nevill edward.nevill at gmail.com
Fri May 29 14:35:13 UTC 2015


On Fri, 2015-05-29 at 15:10 +0100, Andrew Dinn wrote:
> On 27/05/15 16:58, Andrew Dinn wrote:
> > On 27/05/15 16:51, Andrew Haley wrote:
> >> On 05/27/2015 04:38 PM, Edward Nevill wrote:

> The patch includes the following hunk
> 
>   --- a/src/cpu/aarch64/vm/interp_masm_aarch64.hpp	Fri Apr 24 11:01:37
> 2015 +0000
>   +++ b/src/cpu/aarch64/vm/interp_masm_aarch64.hpp	Tue Apr 14 17:19:08
> 2015 +0100
>   @@ -40,6 +40,8 @@
>     protected:
> 
>     protected:
>   +  using MacroAssembler::call_VM_leaf_base;
>   +
>      // Interpreter specific version of call_VM_base
>      virtual void call_VM_leaf_base(address entry_point,
> 
> Icedtea7 builds quite happily without including this hunk. Am I correct
> in believing that it is not needed because it refers to an upstream
> change which has not been pulled down into Icedtea7/JDK7?

Yes, it is a fix for a build failure which snuck in on the back of the
patch. If jdk7 builds without it then it isn't necessary.

However, it shouldn't do any harm and we might as well keep it against
the day when the same upstream change is pulled into jdk7.

Incidentally I missed 2 backports

changeset:   8178:e78935d6bd88
user:        thartmann
date:        Mon Mar 23 10:15:53 2015 +0100
files:       src/cpu/aarch64/vm/aarch64.ad src/cpu/x86/vm/x86_64.ad
description:
8075136: Unnecessary sign extension for byte array access
Summary: Added C2 matching rules to remove unnecessary sign extension
for byte array access.
Reviewed-by: roland, kvn, aph, adinn


changeset:   8177:a4cdf6edcb84
user:        thartmann
date:        Mon Mar 23 10:13:18 2015 +0100
files:       src/cpu/aarch64/vm/aarch64.ad
description:
8075324: Costs of memory operands in aarch64.ad are inconsistent
Summary: Made cost of 'indOffI' consistent to the other memory operands.
Reviewed-by: roland, aph, adinn

You may like to consider these for backporting to jdk7?

All the best,
Ed.




More information about the aarch64-port-dev mailing list