[aarch64-port-dev ] RFR(XXS) JDK-8154379: MIN_STACK_SHADOW_PAGES should equal DEFAULT_STACK_SHADOW_PAGES on aarch64

[Chris Plummer]

On 4/21/16 1:23 PM, Chris Plummer wrote:
> On 4/21/16 12:46 AM, Andrew Dinn wrote:
>> On 20/04/16 17:01, Chris Plummer wrote:
>>> I think the full backout as you suggest makes sense. I can do that.
>>> Thanks for testing.
>> Sorry, I meant to add yesterday that I agree this is the best fix but
>> was distracted from replying by other things.
>>
>> regards,
>>
>>
>> Andrew Dinn
>> -----------
>> Senior Principal Software Engineer
>> Red Hat UK Ltd
>> Registered in UK and Wales under Company Registration No. 3798903
>> Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul
>> Argiry (US)
> Thanks Andrew. So I'll count you and Ed as reviewers if that's ok. 
> I'll push the diff that undoes 8140582:
>
> rc/cpu/aarch64/vm/globals_aarch64.hpp 
> b/src/cpu/aarch64/vm/globals_aarch64.hpp
> --- a/src/cpu/aarch64/vm/globals_aarch64.hpp
> +++ b/src/cpu/aarch64/vm/globals_aarch64.hpp
> @@ -48,9 +48,9 @@
>  #define DEFAULT_STACK_SHADOW_PAGES (4 DEBUG_ONLY(+5))
>  #define DEFAULT_STACK_RESERVED_PAGES (0)
>
> -#define MIN_STACK_YELLOW_PAGES 1
> -#define MIN_STACK_RED_PAGES    1
> -#define MIN_STACK_SHADOW_PAGES 1
> +#define MIN_STACK_YELLOW_PAGES DEFAULT_STACK_YELLOW_PAGES
> +#define MIN_STACK_RED_PAGES    DEFAULT_STACK_RED_PAGES
> +#define MIN_STACK_SHADOW_PAGES DEFAULT_STACK_SHADOW_PAGES
>  #define MIN_STACK_RESERVED_PAGES (0)
>
>  define_pd_global(intx, StackYellowPages, DEFAULT_STACK_YELLOW_PAGES);
>
> thanks,
>
> Chris
>
BTW, does one of the reviewers need Reviewer status for aarch64 pushes?

Chris