[aarch64-port-dev ] RFR: 8148948: aarch64: generate_copy_longs calls align() incorrectly

Edward Nevill edward.nevill at gmail.com
Wed Feb 3 11:45:52 UTC 2016


Hi,

Please review the following:

http://cr.openjdk.java.net/~enevill/8148948/webrev.0/

JIRA: https://bugs.openjdk.java.net/browse/JDK-8148948

The issue is that there are align statements of the form

 __ align(6)

in generate_copy_longs() whereas the correct alignment statement should be

 __ align(64)

In the proposed webrev I have changed the statements to

  __ align(CodeEntryAlignment);

Howver in C1 CodeEntryAlignment is set to 16 for C1 and 64 for C2. I can see no reason why this is the case so I am proposing also changing CodeEntryAlignment to 64 for both C1 & C2.

Other arches set CodeEntryAlignment as follows

sparc: 32
ppc: 128
x86: 32 (c2), 16 (c1)

Thanks,
Ed.




More information about the aarch64-port-dev mailing list