[aarch64-port-dev ] RFR(S): 8087341: C2 doesn't optimize redundant memory operations with G1

[Andrew Dinn]

Hi Roland,

A patch for the AArch64 C2 volatile/CAS generation code which deals with
the effects of your proposed C2 patch is available as a webrev

 http://cr.openjdk.java.net/~adinn/8087341-aarch64/webrev.00/

The webrev includes your patch and mine and is based on the latest hs-comp.

n.b. I have /not/ created a separate issue for the AArch64 part of this
fix. I am not sure whether you want to combine it with your patch or
push it as a separate stage.

n.b. your patch allowed the AArch64 C2 code to be significantly
simplified. That's because it ensures that the Raw memory flows
associated with the GC card marks no longer intermingle with the
AliasIdxBot and oop flows associated with the volatile store/CAS. This
means the job of recognising the signature memory configuration between
leading and trailing memory barriers is much easier.

Testing:

I have verified that this generates correct code for volatile put and
CAS on AArch64 in all 5 relevant GC configurations:

  +UseG1GC
 +UseConcMarkSweepGC +CondCardMark
 +UseConcMarkSweepGC -CondCardMark
 +UseParallelGC +CondCardMark
 +UseParallelGC -CondCardMark

A review from an AArch64 reviewer would be welcome.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul
Argiry (US)