[aarch64-port-dev ] Freeze aarch64/jdk8

Andrew Haley aph at redhat.com
Thu Feb 25 13:38:32 UTC 2016


On 02/25/2016 12:26 PM, Andrew Dinn wrote:
> 
> 
> On 25/02/16 11:57, Andrew Haley wrote:
>> On 02/25/2016 11:53 AM, Andrew Dinn wrote:
>>> Shall I push these changes now? Or do you want to vet some of the patches?
>>
>> Are any of them outside AArch64-specific directories?
> 
> Yes, in quite a few cases -- but they all appear to be backports of
> changes also made upstream. See below for details. n.b. revision ids are
> for aarch64/jdk8/hotspot tree.
> 
> 
> 8136596.patch
> revid: 8561
> 8136596: Remove MemBarRelease when final field's allocation is NoEscape
> or ArgEscape

This is a minor optimization, not submitted to jdk8u.  It's also
somewhat risky.  OK if you make it AARCH64_ONLY.

> 8131645.patch
> revid: 8567
> 8131645: crash on Cavium when using G1

OK: serious crasher bug fix.  Ed, has this been submitted to jdk8u?
It should be because it's not AArch64-specific.

> volcas.patch
> revid: 8568
> Backport optimization of volatile puts/gets and CAS to use ldar/stlr

It's probably safe, but there have been significant reworkings in
this area.

Maybe make this AARCH64_ONLY ?  Please have a look at the generated
code when running G1.

> 8131645-correction.patch
> revid: 8569
> Fix thinko when backporting 8131645. Table ends up being allocated twice.

Yes, needed for 8131645.

> 8138966.patch
> revid: 8573
> 8138966: Intermittent SEGV running ParallelGC

Yes, serious crasher bug.  This is already in jdk8u.
http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/110735ab93ec

Please Ask Andrew Hughes about this one: it should already be in.

> largecodecache.patch
> revid: 8576
> Add support for large code cache
> 
> this makes changes to two files.

The non-AArch64-specific parts of this patch are not used by anything
so should not be included.  The rest is OK.

> 8145438.patch
> revid: 8583
> 8145438: Guarantee failures since 8144028: Use AArch64 bit-test
> instructions in C2
> 
> this makes a small change to src/share/vm/adlc/formssel.cpp

This is OK.  It can't be submitted to jdk8u upstream because
it's only needed for Arch64.  make it AARCH64_ONLY, just for
safety.

Andrew.




More information about the aarch64-port-dev mailing list