[aarch64-port-dev ] 回复：RFR: 8149733: AArch64: refactorchar_array_equals/byte_array_equals/string_equals

[Hui Shi]

Thanks Aleksey!

Can I have another review for this patch?

Regards
Hui

On 24 February 2016 at 22:24, Aleksey Shipilev <aleksey.shipilev at oracle.com>
wrote:

> On 02/24/2016 04:02 PM, Hui Shi wrote:
> > Thanks Andrew! Your comment looks really better and performance doesn't
> > change when run JMHSample_97_ArrayEqual.java
> > <
> http://cr.openjdk.java.net/%7Ehshi/8149733/webrev2/JMHSample_97_ArrayEqual.java>
> test.
> >
> > latest webrev http://cr.openjdk.java.net/~hshi/8149733/webrev3/
> > <http://cr.openjdk.java.net/%7Ehshi/8149733/webrev3/>
>
> Good.
>
> > Following is result with Aleksey's updated test case (-w 5 -wi 3 -i3 -r
> > 10), first 4 group are for base run with base string length 0, 8, 31,
> > 1024. Performance with patch doesn't show same improvement with early
> > test. Only small length string equal tests still show obvious
> improvement.
>
> ...and that's okay for refactoring.
>
> Cheers,
> -Aleksey
>
>
>