[aarch64-port-dev ] RFR: Critical Shenandoah patch for interpreter

[Andrew Hughes]

----- Original Message -----
> I've applied all the patches to my local copy, and here's the combined
> webrev:
> 
> http://cr.openjdk.java.net/~rkennke/merge-shenandoah/webrev.00/
> 
> Sorry, the webrev looks all messed up, but if you ignore all the rev
> lines, it should be good.
> 

Yeah, I was just going to say you have stuff like:

rev 196 : 6719955: Update copyright year
Summary: Update copyright year for files that have been modified in 2008
Reviewed-by: ohair, tbell
rev 178 : 6695819: verify_oopx rax: broken oop in decode_heap_oop
Summary: Code in gen_subtype_check was encoding rax as an oop on a path where rax was not an oop.
Reviewed-by: never, kvn
rev 113 : 6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
Summary: Compressed oops in instances, arrays, and headers. Code contributors are coleenp, phh, never, swamyv
Reviewed-by: jmasa, kamg, acorn, tbell, kvn, rasbold
rev 0 : Initial load

Which version of Mercurial are you using?

I think you made need to update to the latest version of webrev:
http://mail.openjdk.java.net/pipermail/webrev-dev/2016-January/000137.html

> 
> Roman
> 
> Am Mittwoch, den 20.07.2016, 13:02 -0400 schrieb Andrew Hughes:
> > 
> > ----- Original Message -----
> > > 
> > > 
> > > > 
> > > > 
> > > > > 
> > > > > 
> > > > > Also, the following changesets need to be included into the
> > > > > integration
> > > > > repository:
> > > > > 
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/51d8c9b
> > > > > 5de8
> > > > > 7
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/bf65b04
> > > > > 23b2
> > > > > d
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/306ff30
> > > > > 7a68
> > > > > d
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/80821b4
> > > > > 8a83
> > > > > 7
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/b67217c
> > > > > cdc3
> > > > > c
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/01d7999
> > > > > 614f
> > > > > 6
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/1e2c94c
> > > > > 741b
> > > > > b
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/9b261ed
> > > > > 4079
> > > > > 9
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/fa985a2
> > > > > 03d3
> > > > > 9
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/a75014e
> > > > > b896
> > > > > d
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/7cc5667
> > > > > f212
> > > > > 1
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/597d20b
> > > > > b52f
> > > > > b
> > > > > http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/92d0c4d
> > > > > e978
> > > > > 8
> > > > > 
> > > > > Those fix:
> > > > > - Growing of the heap (i.e. when -Xms and -Xmx are different)
> > > > > - Add some missing barriers
> > > > > - Make CAS-obj a loop
> > > > > - Fix freeze in JNI critical region support code
> > > > > 
> > > > > All of those are straightforward backports of corresponding
> > > > > code in
> > > > > jdk9, where the patches have baked for a while. All of them fix
> > > > > some
> > > > > important issues (freezes, failures in concurrency code, etc).
> > > > > Can
> > > > > those be included into the integration repository, together
> > > > > with
> > > > > the
> > > > > original boolean putfield patch asap?
> > > > Are you planning to backport these yourself and post a webrev, or
> > > > do you want me to include them when importing aarch64-jdk8u101-
> > > > b13?
> > > I can backport them myself. Can I collapse them into a single
> > > bigger
> > > patch? Otherwise it might be easier to simply hg import $URL
> > > them...
> > > 
> > Please don't. I'd do a simple hg export --git -r <rev> | hg import -
> > Takes a few minutes. I did something similar to backport aarch64
> > 7 patches to the 2.6 branch yesterday.
> > 
> > > 
> > > Roman
> > > 
> > > 
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222