[aarch64-port-dev ] RFR: 8168909 aarch3264: arm32/64 port contribution cleanups

[Magnus Ihse Bursie]

Hi Bob,

On 2016-11-01 19:54, Bob Vandette wrote:
>>
>> This saves having to grub around in hotspot.m4 to find out what the
>> available options are.
>>
>> The same is true of --with-abi-profile.
> Sure, I’ll update the help text.

I realize this is a late comment, but at some point in time you should 
probably add a AC_MSG_CHECKING/RESULT to print out the value set by 
-with-cpu-port. Note that you need to be careful how you balance these 
two so no additional printing occurs between them. Typically it's 
easiest to just print them directly after one another when you have the 
result. (This is to get all relevant data in the configure log.)

/Magnus

>
>> BTW: The patch to fix the monitor locking problem encountered in jtreg
>> does not seem to have been pushed?
>>
>> diff -r e0c5f8cf07f8 src/share/vm/runtime/sharedRuntime.cpp
>> --- a/src/share/vm/runtime/sharedRuntime.cpp	Mon Oct 10 09:29:51
>> 2016 -0400
>> +++ b/src/share/vm/runtime/sharedRuntime.cpp	Sun Oct 30 21:50:31
>> 2016 +0000
>> @@ -1983,7 +1983,9 @@
>>   JRT_BLOCK_ENTRY(void,
>> SharedRuntime::complete_monitor_locking_C(oopDesc* _obj, BasicLock*
>> lock, JavaThread* thread))
>>     // Disable ObjectSynchronizer::quick_enter() in default config
>>     // on AARCH64 until JDK-8153107 is resolved.
>> -  if (AARCH64_ONLY((SyncFlags & 256) != 0 &&)
>> !SafepointSynchronize::is_synchronizing()) {
>> +  if (ARM_ONLY((SyncFlags & 256) != 0 &&)
>> +      AARCH64_ONLY((SyncFlags & 256) != 0 &&)
>> +      !SafepointSynchronize::is_synchronizing()) {
>>       // Only try quick_enter() if we're not trying to reach a safepoint
>>       // so that the calling thread reaches the safepoint more quickly.
>>       if (ObjectSynchronizer::quick_enter(_obj, thread, lock)) return;
>>
> I was hoping that this change would be pushed directly to JDK 9 and I’d
> bring it into jdk9-arm3264 eventually.  There’s been a bit of discussion on this bug since
> it doesn’t fix the root problem, it just disables an optimization for ARM.
>
> Bob.
>
>
>> All the best,
>> Ed.
>>