[aarch64-port-dev ] RFR: 8170188: jtreg compiler/types/TestMeetIncompatibleInterfaceArrays.java causes JVM crash

[Andrew Haley]

Hi,

On 23/11/16 12:52, Sergey Nazarkin wrote:
> 
> You are right, ZR is not defined at Assembler scope. Anyway, I’ve
> updated review page with updated MacroAssembler. Not sure it starts
> look like eye candy. :)

True.

A few things:

You can get rid of the overload of

  ands(Register Rd, Register Rn, Register Rm,
                enum shift_kind kind = LSL, unsigned shift = 0)

by saying

  using Assembler::ands;
  using Assembler::andsw;

at the top of the file.

What about the other boolean operations?

Do you know if this was C2- or C1-generated code?  C2 should never do
it, and I'm not sure how C1 gets there either.  I get a pass for that
test, so I don't know how or why you got that failure.

Sorry for all the questions...

Andrew.