[aarch64-port-dev ] RFR: 8167595: AArch64: SEGV in stub code cipherBlockChaining_decryptAESCrypt

[Andrew Haley]

Hi,

On 20/09/16 11:09, Ningsheng Jian wrote:

> Jtreg test jdk/test/com/sun/crypto/provider/Cipher/CTS/CTSMode.java
> failed with SIGSEGV on option "-Xcomp -XX:-TieredCompilation".
> 
> The crash happens at stub code cipherBlockChaining_decryptAESCrypt.
> 
> Checking the jdk source code CipherTextStealing.decryptFinal and its
> callee CipherBlockChaining.decrypt/implDecrypt, we can see that
> cipherLen which is passed to the stub code can be 0. The unexpected
> len_reg value makes the load from invalid address.
> 
> The following patch could fix this issue:
> 
> http://people.linaro.org/~ningsheng.jian/webrev/cbc-stub-fix/webrev.00/
> 
> It aligns with the Java code implementation and passed JTreg tests. To
> make code consistent, I also update the encrypt part.
> 
> Could someone please help to take a look at it?

I made some small changes:

http://cr.openjdk.java.net/~aph/8167595/

Given that these changes are so minor, you are still the author.  I
can't commit this today because the hs repo is still closed.

Andrew.