[aarch64-port-dev ] FYI - Fix for 8160376 broke aarch64.

[White, Derek]

I may have misplaced blame here, or something funny is going on.

The link at http://hg.openjdk.java.net/jdk9/hs/hotspot/comparison/ad402ced3a63/src/cpu/aarch64/vm/templateInterpreterGenerator_aarch64.cpp blames 8160376.

But the hg log points to rev 12175, JDK-8166972, which seems more relevant.

I see the RFR went to hotspot-compiler-dev, so there wasn't a hidden review issue.

-----Original Message-----
From: aarch64-port-dev [mailto:aarch64-port-dev-bounces at openjdk.java.net] On Behalf Of White, Derek
Sent: Monday, October 24, 2016 12:07 PM
To: aarch64-port-dev at openjdk.java.net
Subject: [aarch64-port-dev ] FYI - Fix for 8160376 broke aarch64.

There's an un-terminated #ifdef

See changeset at http://hg.openjdk.java.net/jdk9/hs/hotspot/comparison/ad402ced3a63/src/cpu/aarch64/vm/templateInterpreterGenerator_aarch64.cpp

I actually can't see a review request for this change anywhere, but I may have missed it. But there could be a process error here.

Although I appreciate people trying to keep aarch64 up to date in the face of shared changes, it's important that we (aarch64 folks) get to see these changes before they go in.

I've added new bug JDK-8168567<https://bugs.openjdk.java.net/browse/JDK-8168567>.

I'm happy to fix it, unless someone else can get checkin faster than I can....


-          Derek