[aarch64-port-dev ] RFR: AArch64: Fix JNI floating point argument handling

Andrew Dinn adinn at redhat.com
Fri Sep 9 12:59:11 UTC 2016


On 09/09/16 11:10, Andrew Haley wrote:
> On 09/09/16 09:34, Andrew Dinn wrote:
>> Hi Ningsheng,
>>
>> On 08/09/16 10:20, Ningsheng Jian wrote:
>>> I have updated the webrev at:
>>>
>>> http://people.linaro.org/~ningsheng.jian/jni-fix/webrev.01/
>>>
>>> Please help to review it. It passed jtreg tests on my arm server with
>>> fastdebug build.
>>
>> Andrew Haley is on holiday at the moment so I have reviewed this patch.
>> It looks fine and the test passes on my patched build.
> 
> It's good.  I'm surprised (not to say appalled) that we never noticed
> this before now.

Yeah, I was going to run hg blame on the jdk8 tree to see who wrote such
obviously broken code -- but I think it was me so I decided not to bother!

Do we still need someone from Oracle to sponsor this and provide it with
an exemption before it can go into JDK9? Or can you commit it?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the aarch64-port-dev mailing list