[aarch64-port-dev ] [OpenJDK8u] java.nio.Bits.unaligned() doesn't handle aarch64

White, Derek Derek.White at cavium.com
Fri Aug 11 14:20:43 UTC 2017


Thanks for the push!

And I'll send patches for 8u next time. I guess there's no reason not to do a regular webrev.

 - Derek

> -----Original Message-----
> From: Andrew Hughes [mailto:gnu.andrew at redhat.com]
> Sent: Thursday, August 10, 2017 8:11 PM
> To: White, Derek <Derek.White at cavium.com>
> Cc: Andrew Haley <aph at redhat.com>; aarch64-port-dev at openjdk.java.net
> Subject: Re: [aarch64-port-dev ] [OpenJDK8u] java.nio.Bits.unaligned()
> doesn't handle aarch64
> 
> On 4 August 2017 at 23:58, White, Derek <Derek.White at cavium.com>
> wrote:
> > Re-propose fix, now that 8u141 was merged:
> >
> > Updated patch:
> >
> > --- old/src/share/classes/java/nio/Bits.java    2017-08-04
> 18:18:12.562452645 -0400
> > +++ new/src/share/classes/java/nio/Bits.java    2017-08-04
> 18:18:12.482454700 -0400
> > @@ -615,7 +615,8 @@
> >              new sun.security.action.GetPropertyAction("os.arch"));
> >          unaligned = arch.equals("i386") || arch.equals("x86")
> >              || arch.equals("amd64") || arch.equals("x86_64")
> > -            || arch.equals("ppc64") || arch.equals("ppc64le");
> > +            || arch.equals("ppc64") || arch.equals("ppc64le")
> > +            || arch.equals("aarch64");
> >          unalignedKnown = true;
> >          return unaligned;
> >      }
> >
> > - Derek
> >
> 
> I've extended this to cover the case in
> sun.security.provider.ByteArrayAccess, as with the ppc64 version, and
> pushed it:
> 
> http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/64e09337b9b7
> https://bugs.openjdk.java.net/browse/JDK-8186090
> 
> For future contributions, can you please include the patch as an attachment
> as they otherwise get mangled by the mail system.
> 
> Thanks,
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Web Site: http://fuseyism.com
> Twitter: https://twitter.com/gnu_andrew_java
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint
> = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the aarch64-port-dev mailing list