[aarch64-port-dev ] RFR(XS): 8u fails on assert on jtreg compiler/uncommontrap/TestDeoptOOM.java

[Anton Kozlov]

On 14.08.2017 14:31, Felix Yang wrote:
>     +#ifdef ASSERT
>     +    // If there is exception we go to interpreter before code below clear
>     +    // last_sp of current frame
>     +    __ str(zr, Address(rfp, frame::interpreter_frame_last_sp_offset * wordSize));
>     +#endif
> 
> 
>     This works for a debug build, should we do the same thing for a release build?
It's interesting consern. 
As far as I can see, NULL in last_sp of last frame is never checked and so far only the call_VM found it's incorrect.
So I chose to make least intrusive change.

>From other side, rest of interpreter always clear last_sp. Perhaps I missed something, in case last_sp _should_ be cleared, this patch will make investigation harder.
So I agree/ready to change the patch to clear inconditionally.

Thanks,
Anton