[aarch64-port-dev ] RFR: JDK-8185786: AArch64: disable some address reshapings.

[Zhongwei Yao]

On 14 August 2017 at 23:46, Andrew Haley <aph at redhat.com> wrote:
> On 08/08/17 06:23, Zhongwei Yao wrote:
>> Hi, all,
>>
>> Thanks for your review and information!
>>
>> Patch is updated: http://cr.openjdk.java.net/~njian/8185786/webrev.01/
>
> Should this not be
>
>1       // Any use that can't embed the address computation?
>2       for (DUIterator_Fast imax, i = addp->fast_outs(imax); i < imax; i++) {
>3          Node* u = addp->fast_out(i);
>4          if (! u->is_Mem() || u->is_LoadVector() || u->is_StoreVector() || u->Opcode() == Op_StoreCM) {
>5            return;
>6          }
>7          if (addp2->in(AddPNode::Offset)->Opcode() != Op_ConvI2L) {
>8            int scale = 1 << addp2->in(AddPNode::Offset)->in(2)->get_int();
>9            if (VM_Version::expensive_load(u->as_Mem()->memory_size(), scale)) {
>10              return;
>11            }
>12         }
>13        }
>
> ?

Yeah, it will do the same work. As line 4 has already ensured 'u' is
MemNode, which is required at line 9. But such implication is easy to
be ignored, so I make the "u->is_Mem()" checking to be explicit. What
do you think?

>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



-- 
Best regards,
Zhongwei