[aarch64-port-dev ] RFR(S): 8194256 - AARCH64: SIMD shift instructions are incorrectly encoded

[Andrew Haley]

On 28/12/17 14:03, Dmitrij Pochepko wrote:
> 
> webrev: http://cr.openjdk.java.net/~dpochepk/8194256/webrev.01/
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8194256
> 
> 
> I've checked this patch by generating intrinsic which use these 
> instructions and verified assembly code.

Great catch.

(I'll note that this mistake would not have been possible with the
integer instructions, which are tested against the GNU assembler's
encodings whenever we run a debug build.)

The resulting logic is complex and very difficult to understand, but I
can see that's not your fault.  Hopefully no-one will ever have to
look at this code again.  OK, thanks.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671