[aarch64-port-dev ] 8173339: AArch64: Fix minimum stack size computations

[Edward Nevill]

Just one question about this

-#define DEFAULT_STACK_SHADOW_PAGES (4 DEBUG_ONLY(+5))
+// Java_java_net_SocketOutputStream_socketWrite0() uses a 64k buffer on the
+// stack if compiled for unix and LP64. To pass stack overflow tests we need
+// 20 shadow pages.
+#define DEFAULT_STACK_SHADOW_PAGES (20 DEBUG_ONLY(+5))

Is that 20 4K pages or 20 64K pages? If 64K pages we end up allocating 1.2M?

All the best,
Ed.


On Thu, 2017-01-26 at 16:24 +0000, Andrew Dinn wrote:
> The following webrev against jdk9-dev fixes the AArch64 stack size
> computation as JDK-8173339 required by in line with changes made for the
> bug which caused it JDK-8170655
> 
>   http://cr.openjdk.java.net/~adinn/8173339/webrev.0/
> 
> This is proposed for inclusion jdk9 because it is a serious crasher bug.
>