[aarch64-port-dev ] RFR: JDK-8183533 AArch64: redundant registers saving in arraycopy stubs

Andrew Haley aph at redhat.com
Fri Jul 14 14:37:56 UTC 2017


On 14/07/17 05:32, Zhongwei Yao wrote:
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8183533
> 
> Webrev:
> http://cr.openjdk.java.net/~njian/8183533/webrev.00/

OK.

That looks very reasonable.  I note that the PowerPC port is already
doing exactly this.

I'd change the comment

"AAPCS64 temp registers may be clobbered except registers specified in saved_regs"

to

"Callers must specify what registers to preserve in saved_regs.
 Clobbers: r0-r18, v0-v7, v16-v31, except saved_regs."

thus making it explicit.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the aarch64-port-dev mailing list