[aarch64-port-dev ] RFR: 8172144: AArch64: Implement "JEP 270: Reserved Stack Areas for Critical Sections"

[Chris Plummer]

So how then do you test a feature that is in one port and not the other 
if the test can't determine if the feature is present? All it can do is 
detect if something went wrong with the testing, but it does not know if 
the failure is due to a bug or if due to the feature not being present.

Chris

On 3/17/17 2:01 PM, Bob Vandette wrote:
> I’m just saying that the test should run on both the Oracle 64-bit ARM port as well as the aarch64 port and shouldn’t
> be excluded on one or the other implementations.
>
> Bob.
>
>> On Mar 17, 2017, at 4:37 PM, Chris Plummer <chris.plummer at oracle.com> wrote:
>>
>> I'm not sure why you would say that. I would assume that this is an important test for testing the Reserved Stack Area. Not running it on a supported platform would leaving a testing gap IMHO.
>>
>> Chris
>>
>> On 3/17/17 1:15 PM, Bob Vandette wrote:
>>> I don’t think we need a better check.  We shouldn’t have tests that are enabled that don’t run on both
>>> implementations.
>>>
>>> Bob.
>>>
>>>> On Mar 17, 2017, at 4:04 PM, Chris Plummer <chris.plummer at oracle.com> wrote:
>>>>
>>>> Hi Andrew,
>>>>
>>>> This change has inadvertently enabled the test for the Oracle arm64 port, which is now failing occasionally. I filed JDK-8177055. We need a better check than Platform.isAArch64() so we can distinguish between the Oracle arm64 port and the open Aarch64 port. I'm not sure what the answer is at the moment.
>>>>
>>>> thanks,
>>>>
>>>> Chris
>>>>
>>>> On 1/9/17 10:04 AM, Andrew Haley wrote:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8172144
>>>>>
>>>>> Needs a sponsor because it enables the test.
>>>>>
>>>>> http://cr.openjdk.java.net/~aph/8172144/
>>>>>
>>>>> Andrew.
>>