[aarch64-port-dev ] [OpenJDK8u] java.nio.Bits.unaligned() doesn't handle aarch64

[Andrew Hughes]

----- Original Message -----
> On 12/05/17 04:50, Andrew Hughes wrote:
> > 
> >>> Tested on Spark and off-heap memory was being used. Note: The PPC
> >>> fix also patched sun/security/provider/ByteArrayAccess.java, but I
> >>> didn't include this in the patch below (not sure if it matters, or
> >>> how to test it).
> >>
> >> It's not a great idea to introduce a patch that will conflict with a
> >> patch we haven't yet merged.  We will get all the patches from jdk8u
> >> eventually, but we only merge from security updates and peroper
> >> releases.  I think we should add aarch64 support now, given that
> >> upstream jdk8u will never support it.
> > 
> > The 8u one is https://bugs.openjdk.java.net/browse/JDK-8165231
> > 
> > It is one of a number I requested be added to Oracle's CPU releases,
> > given there doesn't seem to be a feature release (currently referred to
> > as 8u152) coming any time. This can be done by adding the
> > 8u-CPU-critical-request tag. See
> > https://bugs.openjdk.java.net/browse/JDK-8165231?jql=labels%20%3D%208u-CPU-critical-request
> > 
> > It seems that some have now been accepted and some rejected, though
> > with no explanation as to the reasoning behind either. Fortunately,
> > 8165231 is one of the ones that has been approved and so will be in
> > 8u141, which is released in July.
> > 
> > https://bugs.openjdk.java.net/browse/JDK-8179839
> 
> OK.  So would you like to handle Derek's change, please?  I'll leave it
> up to you to decide if it's best to wait for 8u141.
> 
> Andrew.
> 
> 

In that case, I'll add it after I've merged 8u141 if no-one has any objections.
It'll then be part of our aarch64 version of 8u141 along with the PPC one.

Doing it then will basically make it a one-liner:

+            || arch.equals("aarch64");

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222