[aarch64-port-dev ] RFR: 8189596: AArch64: implementation for Thread-local handshakes

[Andrew Dinn]

On 23/11/17 14:12, Andrew Haley wrote:
> On 23/11/17 11:30, Andrew Haley wrote:
>> It was quite tricky to get this one right.
>>
>> Some notes:
>>
>> I deleted LIR_Assembler::poll_for_safepoint because it's dead code.
>>
>> I set ThreadLocalHandshakes to true.  This follows x86-64 and is
>> probably the right thing to do, but it does have the disadvantage that
>> it considerably extends the time to safepoint for interpreted code
>> because we only poll at branches.  I think this is probably a bad
>> idea, but again it's the same as x86-64.  OTOH, checking the safepoint
>> bit at every bytecode would seriously bloat the interpreter.  Oh dear.
>>
> 
> http://cr.openjdk.java.net/~aph/8189596-1/
I have reviewed this by eyeball and it all looks good. I still need to
build and run to be 100% sure.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander