[aarch64-port-dev ] RFR: Shenandoah import

[Andrew Dinn]

On 04/10/17 09:42, Aleksey Shipilev wrote:
> On 10/02/2017 02:29 PM, Roman Kennke wrote:
>> Notably, it includes a bunch of changes done by Roland that better isolates Shenandoah specific code
>> paths in C2 (thus minimizing Shenandoah exposure in non-Shenandoah runs).
> 
> Yes, please review for this! This is the most important part in this integration, and we need to get
> it out sooner. src/shared/vm/gc_implementation/shenandoah/ changes are the bulk of the change, and
> you can review this in a cursory manner.
> 
>> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2017-10-02/webrev.00/
> 
> This looks good to me.
> 
> Note about src/share/vm/memory/metaspaceCounters.cpp change: it is needed to avoid bootstrapping
> circularity with Shenandoah. This addition is retracted in our current development forest, along
> with the proper fix. But we need this fix for current integration.
I am looking through this now (about 1/3rd of the way through).
Obviously, I'm mostly concerned to check stuff that might affect
non-Shenandoah code and be sure it is isolated.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander