[aarch64-port-dev ] [RFR] 8u171 Update

Aleksey Shipilev shade at redhat.com
Tue Apr 24 19:01:50 UTC 2018


On 04/24/2018 08:59 PM, Andrew Hughes wrote:
>>> The Shenandoah merge is:
>>> http://cr.openjdk.java.net/~andrew/aarch64-8/u171/hotspot/shenandoah.merge.b10
>>
>> Missing bits in cpp/fixup_cloned_reference:
>>
>>  *) "if (UseG1GC)" should be "if (UseG1GC || UseShenandoahGC)" -- Shenandoah/8u piggybacks on G1 on
>> this path
>>
>>  *) oopDesc::equals is missing, Shenandoah needs it for correctness:
>>
>>    "(java_lang_ref_Reference::queue(clone) == java_lang_ref_ReferenceQueue::ENQUEUED_queue())"
>>
>>    should be:
>>
>>    "(oopDesc::equals(java_lang_ref_Reference::queue(clone),
>> java_lang_ref_ReferenceQueue::ENQUEUED_queue())))"
>>
>> I can fix them after the merge.
>>
> 
> Right, that sounds more like Shenandoah support for  "8192025: Less
> referential references" than a merge issue.
> 
> Have you made the same changes for Shenandoah in 10 & 11?

Yes, we did pick up jdk10 merge with the same change, and it was fixed as above.
jdk11 has the whole thing a bit differently, IIRC.

Thanks,
-Aleksey




More information about the aarch64-port-dev mailing list