[aarch64-port-dev ] RFR (S): 8209193: Fix aarch64-linux compilation after -Wreorder changes

Thomas Schatzl thomas.schatzl at oracle.com
Mon Aug 13 08:12:13 UTC 2018


Hi,

On Fri, 2018-08-10 at 15:56 +0200, Aleksey Shipilev wrote:
> Hi Thomas,
> 
> On 08/10/2018 03:32 PM, Thomas Schatzl wrote:
> >   when crosscompiling to aarch64-linux I found the following errors
> > caused by latest -Wreorder changes.
> 
> Oh yes, many build configs appear broken, see build logs here:
>   https://builds.shipilev.net/openjdk-jdk/
> 

I think ppc64 has been fixed, and the minimal builds are another issue.
Arm32 is fixed too. The only remaining is s390 it seems.

> > It would be nice if aarch64 devs could verify; I cc'ed aarch64 port
> > dev ml, but I do not know if this is the right list for this.
> 
> It is! Red Hat AArch64 people are off this week.
> 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8209193
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8209193/webrev/
> 
> This patch seems to resolve aarch64 build issues for me.
> 
> I have only minor stylistic comments, these can be fixed before the
> push without another review.
> [...]

All fixed. Thanks for your review.

Thomas



More information about the aarch64-port-dev mailing list