[aarch64-port-dev ] RFR(S): 8209783: AArch64: Combine Multiply and Neg operations in C2

[Andrew Haley]

On 08/22/2018 11:49 AM, Andrew Dinn wrote:
> Hi Pengfei,
> 
> On 22/08/18 11:30, Pengfei Li wrote:
>> Thanks for your review. I've run jtreg full tests on an AArch64
>> server. No new failures were found compared to the code base. I've
>> also tested the corner case that the product of two integers is
>> -2147483648 (0x80000000 in Hex). Of course, I could see new
>> instructions like "0x0000ffff81168e54: mneg      w0, w2, w1" are
>> generated if I switch on -XX:+PrintOptoAssembly.
> 
> If it has passed the full jtreg then I'm ok for it to go in as is. It is
> arguably a small enough fix that it can be pushed with only one review.
> However, I'd prefer if someone else (e.g. Andrew Haley) also reviewed it.

It looks reasonable, so why do we need two reviews? Is this some rule
I didn't hear about?

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671