[aarch64-port-dev ] [12] RFR(S): 8207247 AARCH64: Enable Minimal and Client VM builds

Andrew Haley aph at redhat.com
Wed Aug 29 15:34:44 UTC 2018


On 08/29/2018 03:19 PM, Aleksei Voitylov wrote:
> here is an updated webrev: 
> http://cr.openjdk.java.net/~avoitylov/webrev.8207247.02
> 
> I'm not sure it looks cleaner since in_scratch_emit_size is a C2-only 
> concept, though. This was the reason I changed it.

Yeah, I get that, but I want to keep the code history as clean as
possible.

One other thing I noticed: the

+#ifdef COMPILER2
+  const int stub_size = Compile::MAX_stubs_size/2;
+#else
+  const int stub_size = LIR_Assembler::call_stub_size();
+#endif
+
+  address stub = start_a_stub(stub_size);

is an unnecessary complication.  I'm testing this:

  // Max stub size: alignment nop, ldr, br, emit_int64
  address stub = start_a_stub(3 * NativeInstruction::instruction_size + wordSize);

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the aarch64-port-dev mailing list