[aarch64-port-dev ] RFR(xs): Aarch64: ReservedStackAccess may leave stack guard in inconsistent state

Andrey Petushkov andrey.petushkov at gmail.com
Fri Dec 21 13:52:42 UTC 2018


created https://bugs.openjdk.java.net/browse/JDK-8215879
reverted comment, same review URL

Thanks,
Andrey

On Fri, Dec 21, 2018 at 4:13 AM David Holmes <david.holmes at oracle.com>
wrote:

> On 20/12/2018 9:27 pm, Andrey Petushkov wrote:
> > updated webrev
> http://cr.openjdk.java.net/~apetushkov/ReservedStackAccess2/
>
> I don't think the comment:
>
> !   // Safety in insanity.
>
> adds anything useful and is better left as it was.
>
> Thanks,
> David
>
> > if all good, Andrew, may I ask you to push please
> >
> > Thanks,
> > Andrey
> >
> > On Thu, Dec 20, 2018 at 1:11 PM Andrew Haley <aph at redhat.com
> > <mailto:aph at redhat.com>> wrote:
> >
> >     On 12/19/18 9:52 PM, David Holmes wrote:
> >      > They are there to ensure that in product mode if we hit a case not
> >      > exposed by testing then we don't crash. Should never happen but
> ...
> >
> >     Yes, I agree, Thanks.
> >
> >     --
> >     Andrew Haley
> >     Java Platform Lead Engineer
> >     Red Hat UK Ltd. <https://www.redhat.com>
> >     EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
> >
>


More information about the aarch64-port-dev mailing list