[aarch64-port-dev ] RFR: RFR: Bulk integration shenandoah/jdk8u -> aarch64-port/jdk8u-shenandoah 2018-12-13

[Andrew Hughes]

On Thu, 20 Dec 2018 at 21:35, Roman Kennke <rkennke at redhat.com> wrote:
>
>
> >> Please review the following proposed changes:
> >>
> >> This integrates changes from shenandoah/jdk8u into
> >> aarch64-port/jdk8u-shenandoah repository, reaching back to September 2018.
> >> It's bugfixes, improvements and new features that have been originally
> >> done in Shenandoah dev repo, and then backported to Shenandoah JDK8u
> >> repo and tested there for a while too.
> >>
> >> List of changes:
> >> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-12-13/jdk8u-shenandoah-integration-2018-12-13.txt
> >>
> >> Webrev showing only shared-changes:
> >> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-12-13/webrev-shared-only.00/
> >>
> >> Full webrev:
> >> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-12-13/webrev-all.00/
> >>
> >> Thanks,
> >> Roman
> >>
> >
> > Mostly ok, but for:
> >
> > changeset:   10742:c935e0b6b4b2
> > user:        shade
> > date:        Thu Oct 25 20:38:21 2018 +0200
> > summary:     [backport] Cherry-pick JDK-8212673, fix for Node::eqv_uncast
> >
> > This doesn't seem to have been requested for OpenJDK 11 upstream, never mind 8u.
> > Why is it being backported only to shenandoah?
>
>
> Because the orginal issue has been made more or less specifically for
> Shenandoah:
>
> https://bugs.openjdk.java.net/browse/JDK-8212603
>
> and JDK-8212673 fixes an issue with the change. IOW, it's Shenandoah
> specific.
>
> Roman
>

Ok, but is it harmful to other collectors to have it upstream? I'm trying to
minimise our divergence where possible.

8212603 is not in 8u or shenandoah-8u. Is 8212673 still applicable in its
absence as a standalone fix?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222