[aarch64-port-dev ] RFR(XS): 8196868 - AARCH64: ld/st instructions hit guarantee assert while using sp

[White, Derek]

Looks good to me.

 - Derek

> -----Original Message-----
> From: aarch64-port-dev [mailto:aarch64-port-dev-
> bounces at openjdk.java.net] On Behalf Of Andrew Haley
> Sent: Wednesday, February 07, 2018 1:37 PM
> To: Dmitrij Pochepko <dmitrij.pochepko at bell-sw.com>; aarch64-port-
> dev at openjdk.java.net; hotspot-compiler-dev at openjdk.java.net
> Subject: Re: [aarch64-port-dev ] RFR(XS): 8196868 - AARCH64: ld/st
> instructions hit guarantee assert while using sp
> 
> On 07/02/18 17:40, Dmitrij Pochepko wrote:
> > Hi all,
> >
> > please review small patch for JDK-8196868 - AARCH64: ld/st
> > instructions hit guarantee assert while using sp
> >
> > I found a guarantee assert crash in hotspot while trying to write
> > intrinsic with st4 (SIMD load) instruction which write values into
> > stack. It is allowed by specification: SP or general-purpose register
> > can be used for addressing.
> >
> >
> > A reason for this was register encoding call rf(...), which was used
> > originally. This call doesn't expect SP to be passed for encoding,
> > while
> > srf(...) expects SP or general-purpose register.
> >
> >
> > webrev: http://cr.openjdk.java.net/~dpochepk/8196868/webrev.01/
> >
> > CR: https://bugs.openjdk.java.net/browse/JDK-8196868
> >
> >
> > I've tested this patch with my intrinsic and crash is not reproducible
> > anymore. I also run part of jtreg hotspot tests as sanity to ensure
> > nothing got broken and it looks good.
> 
> Yes, this is OK.  Thanks.
> 
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671