[aarch64-port-dev ] RFR(M): JDK-8190428 Minimal Dynamic Constant support for AArch64

Paul Sandoz paul.sandoz at oracle.com
Mon Feb 5 18:38:17 UTC 2018


Hi Dmitry,

I don’t feel qualified to comment on the asm updates, but the general pattern looks right to me. The updates to the tests are good.

Thanks,
Paul.

> On Feb 3, 2018, at 4:43 AM, Dmitry Samersoff <dmitry.samersoff at bell-sw.com> wrote:
> 
> Everybody,
> 
> Please review the changes:
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-8190428/webrev.05/
> 
> The old review thread for AArch64 changes:
> 
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/029435.html
> 
> -Dmitry
> 
> On 02/01/2018 10:33 PM, Paul Sandoz wrote:
>> 
>> 
>>> On Feb 1, 2018, at 10:47 AM, Dmitry Samersoff <dmitry.samersoff at bell-sw.com> wrote:
>>> 
>>> Andrew,
>>> 
>>> On 02/01/2018 06:49 PM, Andrew Haley wrote:
>>>> On 01/02/18 15:33, White, Derek wrote:
>>>>> Dmitry Samersoff has been tracking this for aarch64 as well. He might be able to add some insights - although I'm not sure if has had time to look at the last batch.
>>>>> 
>>>>> https://bugs.openjdk.java.net/browse/JDK-8190428
>>>> 
>>>> OK.  Dmitry, what's the status of this?  I can't remember anything
>>>> being discussed on the AArch64 project list.
>>> 
>>> I didn't look at it since preliminary webrev[1] I sent 29 Nov, need some
>>> time to check wether this code is still correct or not.
>>> 
>>> 1. http://cr.openjdk.java.net/~dsamersoff/JDK-8190428.condy/webrev.04
>>> 
>> 
>> I strongly suspect it will be ok, the condy code did not really change that much, mostly minor tweaks from continual rebasing.
>> 
>> Paul.
>> 
> 



More information about the aarch64-port-dev mailing list