[aarch64-port-dev ] RFR: 8196136: AArch64: Correct register use in patch for JDK-8195685
Andrew Dinn
adinn at redhat.com
Thu Jan 25 12:17:29 UTC 2018
On 25/01/18 11:48, Andrew Haley wrote:
> On 25/01/18 11:24, Andrew Dinn wrote:
>> The following webrev against jdk10 corrects the patch to use a safe
>> register (r19)
>
> OK, but please use r16 instead. It's not used for anything else
> and callee-saved register are precious. At some point we should
> move from using r13 to pass the save SP to r19, so we shouldn't
> use r19 in call stubs becuse it'll be live.
Revised webrev using r16
jira: https://bugs.openjdk.java.net/browse/JDK-8196136
webrev: http://cr.openjdk.java.net/~adinn/8196136/webrev.02/
I modified itable (and vtable) stubs to use r16 instead of r19. Same
testing was successful.
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
More information about the aarch64-port-dev
mailing list