[aarch64-port-dev ] RFR(S): 8204628 [AArch64] Assertion failure in BarrierSetAssembler::load_at

Stuart Monteith stuart.monteith at linaro.org
Fri Jun 8 22:06:45 UTC 2018


Hello,
    Please review a patch for "8204628  [AArch64] Assertion failure in
BarrierSetAssembler::load_at".

Currently you won't be able to build aarch64 debug builds because of
assertions tripping in load_at.
JDK-8203353 refined the decorators somewhat, which worked fine on x86,
but not aarch64.

In this patch, I change the code to match x86's in that access_load_at
is called instead of load_at, which means that
AccessInternal::decorator_fixup is called, which fixes the
expectations of the assertions in load_at and other places. The
accesses of load_at and access_load_at  (and store equivalents) now
match x86.

CR: https://bugs.openjdk.java.net/browse/JDK-8204628

webrev: http://cr.openjdk.java.net/~smonteith/8204628/webrev/

The assertions no longer trip when tested with C1 or C2.

Many thanks,
    Stuart


More information about the aarch64-port-dev mailing list