[aarch64-port-dev ] RFR(S): 8204628 [AArch64] Assertion failure in BarrierSetAssembler::load_at

[Stuart Monteith]

Thanks everyone,
  There is a new patch here:
      http://cr.openjdk.java.net/~smonteith/8204628/webrev.1/

Could someone sponsor this please?

Thanks,
     Stuart


On 9 June 2018 at 09:38, Andrew Haley <aph at redhat.com> wrote:
> Hi,
>
> On 06/08/2018 11:06 PM, Stuart Monteith wrote:
>
>>     Please review a patch for "8204628  [AArch64] Assertion failure in
>> BarrierSetAssembler::load_at".
>>
>> Currently you won't be able to build aarch64 debug builds because of
>> assertions tripping in load_at.
>> JDK-8203353 refined the decorators somewhat, which worked fine on x86,
>> but not aarch64.
>>
>> In this patch, I change the code to match x86's in that access_load_at
>> is called instead of load_at, which means that
>> AccessInternal::decorator_fixup is called, which fixes the
>> expectations of the assertions in load_at and other places. The
>> accesses of load_at and access_load_at  (and store equivalents) now
>> match x86.
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8204628
>>
>> webrev: http://cr.openjdk.java.net/~smonteith/8204628/webrev/
>>
>> The assertions no longer trip when tested with C1 or C2.
>
> Fine by me too. The declaration of BarrierSetAssembler *bs is unused.
>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671