[aarch64-port-dev ] RFR: Bulk integration of Shenandoah 2018-05-15

[Andrew Hughes]

On 15 May 2018 at 15:50, Roman Kennke <rkennke at redhat.com> wrote:
> This integrates latest Shenandoah changes from shenandoah/jdk8u
> repository. It includes all Shenandoah changes since Oct 2017. It's all
> backports from sh/jdk -> sh/jdk10 -> sh/jdk9 -> sh/jdk8u or jdk8u
> specific bugfixes. It's all been reviewed, baked and
> thoroughly tested upstream.
>
> The integration brings lots of major and minor improvements, bugfixes
> and tests.
>
> The list of changesets to be pushed is this:
> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-05-15/jdk8u-shenandoah-integration-2018-05-15.txt
>
> The complete webrev is:
> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-05-15/webrev.00/
>
> It builds release+fastdebug, and passes all hotspot_gc_shenandoah tests.
>
> I'll tag the forest with:
>
> aarch64-shenandoah-jdk8u172-b11--shenandoah-merge-2018-05-15
>
>

In retrospect, I'm thinking I should have at least found time to
review the list of changes, if not the Shenandoah code.

In working with this, I've run across changes like this:

changeset:   10408:908723b9f760
user:        sangheki
date:        Thu Feb 09 19:08:32 2017 -0800
summary:     Cherry-pick JDK-8173013: JVMTI tagged object access needs
G1 pre-barrier

changeset:   10409:388a0e0523c2
user:        mdoerr
date:        Tue Sep 06 13:01:27 2016 +0200
summary:     Cherry-pick JDK-8165489: Missing G1 barrier in
Unsafe_GetObjectVolatile

changeset:   10410:ea3ab1a51237
user:        shade
date:        Wed Feb 07 21:53:38 2018 +0000
summary:     Cherry-pick JDK-8187577: JVM crash during gc doing
concurrent marking

We shouldn't be backporting upstream changes into just Shenandoah.
These should go first to jdk8u/jdk8u,
and then, if we need them before they make an upstream 8u release,
they should go to aarch64/jdk8u.

Having them coming in via Shenandoah means we're creating differences
between aarch64/jdk8u
and aarch64/shenandoah-jdk8u which aren't Shenandoah-specific. Please
let's not do that.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222