[aarch64-port-dev ] RFR: JDK-8205004: AArch64: fix failures in jtreg ArraysEqCmpTest

[Dmitrij Pochepko]

Hi,

I think you can just move existing checks:

5148     cmp(cnt2, cnt1);
5149     br(NE, DONE);

and

5141     cmpoop(a1, a2);
5142     br(EQ, SAME);

before jump to short case: 5140 br(LE, SHORT); // short or same

Then you don't need to add any additional code.

(cmpoop(a1, a2) check should go first, because cnt1 and cnt2 loads are 
possibly still executed)

Thanks,
Dmitrij

On 14.06.2018 16:26, Joshua Zhu wrote:
> Hi,
>
> Please review the following change.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8205004
> Webrev: http://cr.openjdk.java.net/~zyao/8205004/
>
> This bug causes three failures in Jtreg ArraysEqCmpTest.
> test ArraysEqCmpTest.testArray(byte[])
> test ArraysEqCmpTest.testArray(unsigned byte[])
> test ArraysEqCmpTest.testArray(char[])
>
> Array length needs to be compared for short arrays.
> Please see detailed description in JBS.
>
> Best Regards,
> Joshua
>