[aarch64-port-dev ] RFR: JDK-8205004: AArch64: fix failures in jtreg ArraysEqCmpTest

[Joshua Zhu]

Hi Andrew,

Thanks for your review!
I think you are saying read barrier in ShenandoahBarrierSetAssembler::obj_equals() implementation.
Therefore I wonder why here we should directly compare these two oop instead of cmpoop.
And see current MacroAssembler::arrays_equals(), cmpoop is already used for compare in same scenario.
Hence I think cmpoop(a1, a2) should also be applied here for short path?

Best Regards,
Joshua

> -----Original Message-----
> From: Andrew Haley <aph at redhat.com>
> Sent: Tuesday, June 19, 2018 8:48 PM
> 
> On 06/19/2018 01:17 PM, Dmitrij Pochepko wrote:
> > this one looks good for me. Let's wait for official reviewer to
> > approve it and then I'll be happy to push it.
> 
> OK, but cmpoop isn't right here: use a straight compare.  When Shenandoah
> goes in we'll have a write barrier on the dest anyway.
> No need to ask for approval with that change.
> 
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671