[aarch64-port-dev ] RFR: JDK-8205004: AArch64: fix failures in jtreg ArraysEqCmpTest
Joshua Zhu
Joshua.Zhu at arm.com
Wed Jun 20 08:26:52 UTC 2018
http://hg.openjdk.java.net/jdk/jdk/file/e810abb27deb/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#l5134
Best Regards,
Joshua
> -----Original Message-----
> From: Andrew Haley <aph at redhat.com>
> Sent: Wednesday, June 20, 2018 4:16 PM
>
> On 06/20/2018 08:26 AM, Joshua Zhu wrote:
>
> > I think you are saying read barrier in
> > ShenandoahBarrierSetAssembler::obj_equals() implementation.
> > Therefore I wonder why here we should directly compare these two oop
> > instead of cmpoop.
>
> Yes.
>
> > And see current MacroAssembler::arrays_equals(), cmpoop is already
> > used for compare in same scenario. Hence I think cmpoop(a1, a2)
> > should also be applied here for short path?
>
> Where exactly, and in which repo? I can't see it, and I suspect that it's wrong.
>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the aarch64-port-dev
mailing list