[aarch64-port-dev ] RFR(M): 8196402: AARCH64: create intrinsic for Math.log

[Dmitrij Pochepko]

Hi,

actually I updated and posted sin and cos at the same time as log, 
almost simultaneously.


Thanks,
Dmitrij

On 20.06.2018 11:31, Andrew Dinn wrote:
> Hi Dmitrij,
>
> On 18/06/18 19:53, Dmitrij Pochepko wrote:
>> I added lots of documentation in a same manner as in Math::sin/cos patch.
>>
>> Please take a look at updated webrev:
>> http://cr.openjdk.java.net/~dpochepk/8196402/webrev.05/
> I am sorry I have not been able to work through the details of the
> actual generated code with enough attention to assess it's correctness
> (I have been very busy trying to check a fix for breakage to volatile
> handling caused by recent changes to the GC interface). I believe Andrew
> (Haley)'s and Derek's reviews are all you need in order to commit.
>
> I did work through the comments, name changes etc. The code is much
> improved and clearly indicates how the generated routine is supposed to
> operate, which means that if any error does turn up it should be
> possible to understand and fix it. Thank you for making a very helpful
> improvement.
>
> I'll do my best to find time to work through the sin and cos code once
> it is similarly commented.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander