[aarch64-port-dev ] RFR(L): 8197405: Improve messages of AbstractMethodErrors and IncompatibleClassChangeErrors.
Andrew Haley
aph at redhat.com
Fri Mar 2 08:48:37 UTC 2018
On 02/03/18 01:54, Ningsheng Jian wrote:
> Hi Goetz,
>
> On 28 February 2018 at 19:41, Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com> wrote:
>> Hi,
>>
>> The debug build of our nightly test showed an issue of our latest builds.
>> Thus new webrev with change in throw_AbstractMethodErrorWithMethod()
>> http://cr.openjdk.java.net/~goetz/wr18/8197405-ameExMsg/webrev.05/
>>
>> Besides the one problem in my test which is fixed by the new webrev,
>> all nightly tests were green.
>>
>
> I am not a reviewer. Just eyeballed the aarch64 changes:
>
> src/hotspot/cpu/aarch64/vtableStubs_aarch64.cpp:
>
> 209 __ far_jump(RuntimeAddress(SharedRuntime::get_handle_wrong_method_stub());
>
> Another ")" is missing at the end?
>
> Compared to other ports, the aarch64 invokeinterface should also be
> updated. Since you've disabled the tests on aarch64, this can also be
> fixed in another patch. CCed aarch64 people.
Hi,
Since you've already reviewed this, can you please fix it?
--
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the aarch64-port-dev
mailing list