[aarch64-port-dev ] RFC 8169201: Montgomery multiply intrinsic should use correct name

[Andrew Hughes]

On 7 March 2018 at 15:37, Andrew Haley <aph at redhat.com> wrote:
> On 02/03/18 10:16, Aleksey Shipilev wrote:
>> We have recently pulled from aarch64-port/jdk8u to shenandoah/jdk8u, and got interesting bugs.
>>
>> In Shenandoah code, we *do* care about stub names for analysis/verification. In upstream, there is a
>> fix for "Montgomery multiply intrinsic should use correct name", which is missing in current
>> aarch64-port/jdk8u:
>>   https://bugs.openjdk.java.net/browse/JDK-8169201
>>
>> Per repo status:
>>  - aarch64-port/jdk8u DOES NOT have it

This fix isn't in any version of 8u. So the first thing to do is
request a backport on
the jdk8u-dev list.

>>  - aarch64-port/sheandoah-jdk8u has it from our fixes
>>  - shenandoah/jdk8u has it from our fixes
>>  - shenandoah/jdk9 has it from upstream
>>  - shenandoah/jdk10 has it from upstream
>>  - shenandoah/jdk has it from upstream
>>
>> This is a landmine during merges, because we can always accidentally reintroduce the bug. Maybe it
>> makes sense to pick up JDK-8169201 to aarch64-port/jdk8u?
>
> Absolutely, yes.  Everything from the relevant upstream repos should go in unless
> there is some strong reason otherwise.
>

No, not everything. We work to specific release tags with jdk8u so we
match proprietary JDK releases as
much as possible, rather than random snapshots of the jdk8u tree.

> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222