[aarch64-port-dev ] [RFR] 8u162 Upstream Sync

[Andrew Hughes]

On 21 March 2018 at 18:58, Aleksey Shipilev <shade at redhat.com> wrote:

snip...

>>
>> Yeah, I wondered about that oop cast.
>>
>> Is there a reason it is removed from the Shenandoah version?
>> It's not obvious from the code.
>
> I think it is to avoid accidental match with oopDesc::operator== that has additional checking in
> Shenandoah code.
>

Oh, ok. I thought it might have been some build/compiler failure, but
saw no issues when
building with the cast.

I forgot that C++ allows operator semantics to be changed :/

I've added it back on top of the merge and pushed.

>> What versions are you comparing here? When I looked at
>> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot, it had a host
>> of other changes too, and http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot
>> doesn't yet have 8180855.
>
> I have just picked up your 8u162 sync to http://hg.openjdk.java.net/shenandoah/jdk9/hotspot, and now
> it has 8180855, see:
>  https://builds.shipilev.net/patch-openjdk-shenandoah-jdk8/2018-03-21-v156-vs-b08b1e9e2963/src/share/vm/compiler/oopMap.cpp.sdiff.html

Oh, I see now... I was expecting you'd merged from
aarch64/jdk8u-shenandoah, not aarch64/jdk8u.

>
> -Aleksey
>
>
>



-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222