[aarch64-port-dev ] RFR: Bulk integration of Shenandoah 2018-05-15

[Andrew Haley]

On 05/17/2018 06:51 PM, Aleksey Shipilev wrote:
> On 05/17/2018 07:41 PM, Andrew Haley wrote:
>> That looks reasonable.
> 
> Have you reviewed the entire patch already? Oh wow, that was fast! I suspected it would take a full
> day to read through them.

I looked through the list of changes and they seemed reasonable.  I
rather assumed that the changes themselves had already been reviewed
as part of the Shenandoah process.  If not, I'm going to withdraw my
consent!  In any case, I assume that a Shenadoah contributor will look
them over too.

>> Is there a well-defined process for handling changes as the GC
>> interface progresses in upstream trunk?  Is it a matter of
>> back-porting the GC interface to JDK 8, or do you still do things the
>> "old" way?
> 
> We are trying our best not to touch the shared parts in backports,
> preferring to be slightly less performance efficient with the
> benefits for our own development sanity. Backporting the JDK 10+ GC
> interface to JDK 8 would be an insane endeavor.

I thought so.

> So, sh/jdk8, sh/jdk9, sh/jdk10, sh/jdk all touch the runtime in
> slightly different ways, but not frustratingly different. Most of
> the barrier logic is encapsulated in ShenandoahBarrierSet and
> friends. The actual calls around the runtime are one-liner
> differences.

Thanks.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671