[aarch64-port-dev ] RFR(M): 8196402: AARCH64: create intrinsic for Math.log

[Andrew Haley]

On 05/21/2018 02:55 PM, Dmitrij Pochepko wrote:
> webrev: http://cr.openjdk.java.net/~dpochepk/8196402/webrev.01/
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8196402

This looks basically reasonable, given that it seems to be a somewhat
straightforward adaptation of the x86 code.  However, a couple of
things:

The assembler changes should be parameterized as much as possible.
For example, fmlavvd, fmulxvsd, and fmulxssd are cases of the "AdvSIMD
vector x indexed element" class.  fmlavvd is a case of "AdvSIMD three
same", some of which already exist.  If you can extend an existing
group of instructions, please do.

Given that this is an adaptation of the Intel code, please do two
things:

Put it in the same place that corresponds to its position in the x86
files.

Keep Intel's copyright.

Thanks.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671