[aarch64-port-dev ] Remove cmp(reg, imm) altogether?

[Joshua Zhu]

Then in addition to previous implementation, we mark the following function as deprecated:
	void cmp(Register Rd, unsigned imm) __attribute__ ((deprecated));
This will trigger a compile-time warning when this function is used.
Users are required to do explicit type conversion for
	void cmp(Register Rd, char imm)

Best Regards,
Joshua

> -----Original Message-----
> From: Andrew Haley <aph at redhat.com>
> Sent: Friday, May 25, 2018 4:30 PM
> To: Joshua Zhu <Joshua.Zhu at arm.com>; aarch64-port-
> dev at openjdk.java.net
> Cc: nd <nd at arm.com>
> Subject: Re: [aarch64-port-dev ] Remove cmp(reg, imm) altogether?
> 
> On 05/25/2018 08:25 AM, Joshua Zhu wrote:
> > How about below implementation?
> > 	void cmp(Register Rd, char imm)
> > imm is changed into type "char", has only one byte.
> > When engineers look into this function, they will wonder why imm has size
> limitation.
> > Then comments are added here to emphasize immediate operand has 12
> bits limitation.
> 
> I don't think there would be any warning, though: the conversion would be
> performed silently.
> 
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671