[aarch64-port-dev ] RFR: Bulk integration of Shenandoah 2018-05-15

Roman Kennke rkennke at redhat.com
Thu May 31 08:37:46 UTC 2018


Am 17.05.2018 um 20:06 schrieb Aleksey Shipilev:
> On 05/17/2018 08:02 PM, Andrew Haley wrote:
>> On 05/17/2018 06:51 PM, Aleksey Shipilev wrote:
>>> On 05/17/2018 07:41 PM, Andrew Haley wrote:
>>>> That looks reasonable.
>>>
>>> Have you reviewed the entire patch already? Oh wow, that was fast! I suspected it would take a full
>>> day to read through them.
>>
>> I looked through the list of changes and they seemed reasonable.  I
>> rather assumed that the changes themselves had already been reviewed
>> as part of the Shenandoah process.  If not, I'm going to withdraw my
>> consent!  In any case, I assume that a Shenadoah contributor will look
>> them over too.
> 
> Yeah, we are sure about the Shenandoah parts. But the goal for this review is to look very carefully
> if this does any weird stuff that affects non-Shenandoah parts. The bulk of the patch is in
> gc/shenandoah, but there are also a few changes in shared code (mostly reverts) which would enjoy a
> fresh pair of eyes.
> 

Has anybody else gotten to review this in the meantime? Is it ok to go?

Roman




More information about the aarch64-port-dev mailing list